Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection: Python api support #1071

Merged
merged 2 commits into from
Jul 23, 2022

Conversation

inocsin
Copy link
Contributor

@inocsin inocsin commented May 18, 2022

Signed-off-by: inocsin vcheungyi@163.com

Description

Support python api based on #802 and https://github.com/pytorch/TensorRT/tree/collections

Type of change

  • Support python api

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

Signed-off-by: inocsin <vcheungyi@163.com>
@facebook-github-bot
Copy link
Contributor

Hi @inocsin!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@narendasan narendasan added component: core Issues re: The core compiler component: api [Python] Issues re: Python API and removed component: core Issues re: The core compiler component: api [Python] Issues re: Python API labels May 20, 2022
Signed-off-by: inocsin <vcheungyi@163.com>
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@@ -179,7 +180,11 @@ PYBIND11_MODULE(_C, m) {
.def_readwrite("format", &Input::format);

py::class_<InputSignature>(m, "InputSignature")
.def(py::init<>())
.def(pybind11::init([](py::object py_obj) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the namespace pybind11? is this something different?

@narendasan narendasan requested a review from bowang007 July 1, 2022 00:19
@ncomly-nvidia ncomly-nvidia added the release: v1.2 Tagged to be included in v1.2 label Jul 11, 2022
@narendasan narendasan merged commit c5ed524 into pytorch:collections Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: core Issues re: The core compiler release: v1.2 Tagged to be included in v1.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants