This repository was archived by the owner on Aug 7, 2024. It is now read-only.
[6/x] switch inference tests to use Float8Linear #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Since inference logic isn't used yet, saving some time and just switching the tests directly instead of testing both versions. Test Plan: ``` pytest test/test_inference_flows.py ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jul 2, 2024
facebook-github-bot
added
the
CLA Signed
vkuzo
added a commit
that referenced
this pull request
Jul 2, 2024
Summary: Since inference logic isn't used yet, saving some time and just switching the tests directly instead of testing both versions. Test Plan: ``` pytest test/test_inference_flows.py ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 6385e321610a0c5a64cc37bc5f2f178c263f2616 Pull Request resolved: #297
This was referenced Jul 2, 2024
|
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in 88d9407. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Since inference logic isn't used yet, saving some time and just
switching the tests directly instead of testing both versions.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D59305794