Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore missing __file__ #476

Merged
merged 2 commits into from
Jan 14, 2020
Merged

Ignore missing __file__ #476

merged 2 commits into from
Jan 14, 2020

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Nov 4, 2019

No description provided.

jayvdb added 2 commits November 4, 2019 15:00
@jayvdb
_build_tlz: Ignore missing __file__
6864aab 
Many Python freezer tools have loaders that either do not set
__file__ or they set __file__ with a guess, or it triggers a
slower load process.
@jayvdb
test_tlz: Ignore missing __file__
e6d27a2 
Skip asserts if __file__ is missing.
@jayvdb jayvdb mentioned this pull request Nov 4, 2019
Open
45 tasks
@eriknw
Copy link
Member

eriknw commented Jan 14, 2020

Which module doesn't have __file__? Regardless, this looks fine to me. Thanks @jayvdb!

@eriknw eriknw merged commit afef2c1 into pytoolz:master Jan 14, 2020
@jayvdb
Copy link
Contributor Author

jayvdb commented Jan 14, 2020

@eriknw , none have __file__ if toolz is used in a zipapp, or PyOxidizer app, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayvdb @eriknw