curry memoize by default.
#146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a cache to be provided when using `memoize` as a decorator.
|
|
||
| @curry(memoize, cache={0: 0, 1: 1}) | ||
| # Provide a cache with initial values to `memoize`. This works as a decorator | ||
| # because `memoize` is curried (see `toolz.curry`) by default. |
There was a problem hiding this comment.
I recommend skipping this explanation. I don't think many of our readers will know that this is strange and the reference to curry probably makes some people tune out.
There was a problem hiding this comment.
Good point. Should I remove the comment in the docstring too?
|
An argument against this PR is that |
|
+1 |
|
Cool. Time to merge? |
|
Merging. I also want to ping #147 here for reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a cache to be provided when using
memoizeas a decorator.