Make history persistent #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create 'load' function to load the conversation in the archive file to history and call it when application is starting
Add Automatically load the last saved chat into history.
- Load chats in the data directory to history - When a new chat is created, save in a file - Remove default archive file - Remove Save history feature (CTRL-S)
update README with the persistent history feature
pythops
reviewed
Dec 5, 2024
src/history.rs
Outdated
| Ok(_) => { | ||
| let notif = Notification::new( | ||
| format!("Chat saved to `{}` file", archive_file_name), | ||
| format!("Chat saved to `{}` file", file_path.display()), |
There was a problem hiding this comment.
Maybe a message like Chat Saved is enough, no need to mention the file
pythops
reviewed
Dec 5, 2024
src/history.rs
Outdated
Comment on lines
114
to
117
| format!( | ||
| "Chat loaded in history from `{:?}` files", | ||
| directory_path.display() | ||
| ), |
There was a problem hiding this comment.
Same here, just History loaded is enough as a message
pythops
reviewed
Dec 5, 2024
|
Great job 👏 There is few things we can add, maybe in other PR:
What do you think ? |
pythops
approved these changes
Dec 5, 2024
Yes it's a good idea, i created a new issue (#41 ) for this features, if anyone want to make a new PR |
|
I will merge this one and we can continue on other PRs |
This was referenced Dec 5, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After review of the pull request #39, add feature of the issue #33
Changes: