Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reworked Release Workflow. Updated Changeme. Added Windows Support. #26

Merged
merged 13 commits into from
Jun 1, 2024
Merged

Reworked Release Workflow. Updated Changeme. Added Windows Support. #26

merged 13 commits into from
Jun 1, 2024

Conversation

WyvernIXTL
Copy link
Contributor

  • Reworked release workflow completely (also tested it).
  • Removed unmaintained actions.
  • Updated changelog to keepachangelog 1.1.0 .
  • Added path of config to readme.

closes #25

@WyvernIXTL
Copy link
Contributor Author

This took positively 4h

@WyvernIXTL WyvernIXTL changed the title Reworkex Release Workflow. Updated Changeme. Added Windows Support. Reworked Release Workflow. Updated Changeme. Added Windows Support. May 31, 2024
pythops
pythops reviewed Jun 1, 2024
View reviewed changes
pythops
pythops reviewed Jun 1, 2024
View reviewed changes
@WyvernIXTL
Copy link
Contributor Author

To test the github action I have to add a tag. Don't be frightened. I'll remove the tag afterwards.

@WyvernIXTL
Copy link
Contributor Author

I believe I resolved everything.

@WyvernIXTL
Copy link
Contributor Author

WyvernIXTL commented Jun 1, 2024 •
edited
Loading

Though I must say because of musl and the non archiving of the binary, the update is smaller than hoped. (spaghetti code 😆 )

@WyvernIXTL
Copy link
Contributor Author

WyvernIXTL commented Jun 1, 2024 •
edited
Loading

I could put the linux part into a different step. This would decrease the spaghettiness a lot.

@pythops
Copy link
Owner

pythops commented Jun 1, 2024

Thanks so much for your changes, really appreciate 🙏

@pythops pythops merged commit 07c5efb into pythops:master Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pythops pythops pythops left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows support
2 participants
@WyvernIXTL @pythops