Add Grant to profile dashboard #3993
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
estyxx
force-pushed
the
add-grant-to-profile-dashboard
branch
from
d375b89
to
2ae6af4
Compare
estyxx
force-pushed
the
add-grant-to-profile-dashboard
branch
from
2ae6af4
to
867df62
Compare
estyxx
force-pushed
the
add-grant-to-profile-dashboard
branch
from
867df62
to
3362999
Compare
estyxx
force-pushed
the
add-grant-to-profile-dashboard
branch
from
3362999
to
83ea6f8
Compare
| "If you're facing financial difficulties and wish to attend PyCon Italia, our grant application form is currently open. Submit your grant request today!", | ||
| "profile.myGrant.noGrant.submitGrant": "Request a grant", | ||
| "profile.myGrant.noGrant.body.closed": | ||
| "The grant application form is currently closed. Stay tuned for future opportunities.", |
There was a problem hiding this comment.
Stay tuned for future opportunities? what does this mean?
The grant application form is now closed. Unfortunately we can't accept new applications after our deadline.
There was a problem hiding this comment.
I still see the old text here @estyxx
| )} | ||
|
|
||
| <Grid cols={3} gap="small" fullWidth> | ||
| <GridColumn> |
There was a problem hiding this comment.
do you need the GridColumn in all those rows?
There was a problem hiding this comment.
mm no apparently works also with div
| year: "numeric", | ||
| }); | ||
|
|
||
| return ( |
There was a problem hiding this comment.
can we split this into some sub-components? it is quite a big component
There was a problem hiding this comment.
I moved the table in a separate component. Do you think it's enough? or should I split also the "next steps" section maybe? 🤔
There was a problem hiding this comment.
this component is still a bit hard to read but can't think of anything specific now without cloning the code locally and changing it a bit
frontend/src/components/my-grant-profile-page-handler/index.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/my-grant-profile-page-handler/no-grant.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/my-grant-profile-page-handler/my-grant.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/my-grant-profile-page-handler/sidebar.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/my-grant-profile-page-handler/my-grant.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/my-grant-profile-page-handler/no-grant.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/my-grant-profile-page-handler/profile-with-my-grant.graphql
Show resolved
Hide resolved
estyxx
force-pushed
the
add-grant-to-profile-dashboard
branch
from
1bddff4
to
af9b496
Compare
estyxx
force-pushed
the
add-grant-to-profile-dashboard
branch
from
af9b496
to
0889156
Compare
| "Your application is under review. No further action is needed from you at this moment.", | ||
| "profile.myGrant.status.rejected": "Rejected", | ||
| "profile.myGrant.status.rejected.nextSteps": | ||
| "Unfortunately, your grant request has been rejected due to limited funds and a high number of applications. For details, check the email we sent you.", |
There was a problem hiding this comment.
does the email contain information?
There was a problem hiding this comment.
There was a problem hiding this comment.
then can we remove that phrase from the text? maybe something like:
Unfortunately, your grant request has been rejected due to limited funds and a high number of applications. We hope you will be able to join us regardless!
Not sure I understand what you meant. I had two Grids, I "merged" them... |
Co-authored-by: Alessia Marcolini <98marcolini@gmail.com>
|
@alessiamarcolini and @marcoacierno I applied your suggestions, do you think we can merge this? can you have a final look, please? thanks |
marcoacierno
changed the title
|
Gender is optional and when it is missing it appears like this? 
|
| @@ -0,0 +1,7 @@ | |||
| import { Text } from "@python-italia/pycon-styleguide"; | |||
|
|
|||
| export const Title = ({ children }: { children: React.ReactNode }) => ( | |||
There was a problem hiding this comment.
this component name is way too generic
| "Unfortunately, your grant request has been rejected due to limited funds and a high number of applications. For details, check the email we sent you.", | ||
| "profile.myGrant.status.approved": "Approved", | ||
| "profile.myGrant.status.approved.nextSteps": | ||
| "Your grant request is approved. We will send you an email very soon with further instructions. Check your email regularly.", |
There was a problem hiding this comment.
Your grant request has been approved! We will send you an email very soon with further instructions, please check your email regularly.
| "profile.myGrant.editInfo": | ||
| "Ensure all the information provided are correct. You have until {editDeadline} to edit your information.", | ||
| "profile.myGrant.manage": "Manage", | ||
| "profile.myGrant.manage.warning": `If your plans change or you cannot attend the conference anymore, please let us know by clicking the 'Manage' button to refuse your grant or email us at {grantsEmail} as soon as possible. |
There was a problem hiding this comment.
"If your plans change or you cannot attend the conference anymore" reads weird to me, as if plans changing and cannot attend the conference are two separate things that can happen?
Also if we can avoid them contacting us via email is better, so I would advertise the path we want them to take, i.e. they should use the manage button.
I would just say:
If you cannot attend the conference anymore please let us know by using the 'Manage' button to refuse your grant as soon as possible.
Failing to notify us may impact your eligibility for financial aid in the future.
| Failing to notify us may impact your eligibility for financial aid at future events.`, | ||
| "profile.myGrant.noGrant.heading": "You haven't requested a grant", | ||
| "profile.myGrant.noGrant.body.canSubmit": `If you're facing financial difficulties and wish to attend PyCon Italia, our grant application form is currently open! | ||
| Find our more information {grantInfoLink} and submit your application below.`, |
There was a problem hiding this comment.
Why do we have a link to grant info here? The button below should redirect them to grant info, I don't see a point in having a link both in the text and the button below?
Find out more on our website below
We could even just remove this line, as we have the button that could say "Find out more"
| "profile.myGrant.noGrant.body.closed": | ||
| "The grant application form is currently closed. Stay tuned for future opportunities.", | ||
| "profile.myGrant.noGrant.body.openingSoon": | ||
| "Our grant application form will open soon! Check our {grantInfoLink} for more details.", |
There was a problem hiding this comment.
why we have a link in the text here?
There was a problem hiding this comment.
why not? to the info page, Alessia suggested
There was a problem hiding this comment.
The button below already links to it?
| "profile.myGrant.editInfo": | ||
| "Assicurati che tutte le informazioni fornite siano corrette. Hai tempo fino al {editDeadline} per modificare il tuo grant.", | ||
| "profile.myGrant.manage": "Gestisci", | ||
| "profile.myGrant.manage.warning": `Se i tuoi piani cambiano o non puoi più partecipare alla conferenza, per favore faccelo sapere cliccando sul pulsante 'Gestisci' per rifiutare il tuo grant o inviaci un'e-mail a {grantsEmail} il prima possibile. |
There was a problem hiding this comment.
same as above, "Se i tuoi piani cambiano o non puoi più partecipare alla conferenza" doesn't make sense to me
maybe let's rewrite the english one and then translate it with chatgpt?
| "profile.myGrant.noGrant.body.closed": | ||
| "Il modulo per la richiesta di grant è al momento chiuso. Purtroppo non possiamo accettare nuove richieste dopo la scadenza.", | ||
| "profile.myGrant.noGrant.body.openingSoon": | ||
| "Il nostro modulo per la richiesta di grant aprirà presto! Visita la nostra {grantInfoLink} per ulteriori dettagli.", |
There was a problem hiding this comment.
"Il nostro modulo" is weird "Il form per la richiesta grant"?
Why
How to test it
#3931
