Move best practices out of "Type Stubs" doc into guide on writing stubs. #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of an effort to integrate the standalone "Type Stubs" doc into the rest of the typing documentation. See python#1815 for more context. For python#1605.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Also fixes some silly wording.
srittau
approved these changes
Jul 25, 2024
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
@srittau @JelleZijlstra Thanks for the reviews! Is there anyone else you'd recommend I request a review from or any other procedural steps to take before merging? |
JelleZijlstra
approved these changes
Jul 26, 2024
|
I think this is fine as is. This is not a spec, but an Informal document, so we can always easily amend it if something comes up. |
hauntsaninja
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of an effort to integrate the standalone "Type Stubs" doc into the rest of the typing documentation. See
#1815 for more context.
For #1605.