Prepend bases on first subscription (#386)

* Prepend bases with _gorg on subscription * Simplify code
python · Feb 3, 2017 · 1229efb · 1229efb
1 parent d149ce7
commit 1229efb
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/python2/test_typing.py b/python2/test_typing.py
@@ -521,6 +521,7 @@ def test_basics(self):
         Y[unicode]
         with self.assertRaises(TypeError):
             Y[unicode, unicode]
+        self.assertIsSubclass(SimpleMapping[str, int], SimpleMapping)
 
     def test_generic_errors(self):
         T = TypeVar('T')

diff --git a/python2/typing.py b/python2/typing.py
@@ -1169,8 +1169,10 @@ def __getitem__(self, params):
             _check_generic(self, params)
             tvars = _type_vars(params)
             args = params
+
+        prepend = (self,) if self.__origin__ is None else ()
         return self.__class__(self.__name__,
-                              self.__bases__,
+                              prepend + self.__bases__,
                               dict(self.__dict__),
                               tvars=tvars,
                               args=args,

diff --git a/src/test_typing.py b/src/test_typing.py
@@ -552,6 +552,7 @@ def test_basics(self):
         Y[str]
         with self.assertRaises(TypeError):
             Y[str, str]
+        self.assertIsSubclass(SimpleMapping[str, int], SimpleMapping)
 
     def test_generic_errors(self):
         T = TypeVar('T')

diff --git a/src/typing.py b/src/typing.py
@@ -1096,8 +1096,10 @@ def __getitem__(self, params):
             _check_generic(self, params)
             tvars = _type_vars(params)
             args = params
+
+        prepend = (self,) if self.__origin__ is None else ()
         return self.__class__(self.__name__,
-                              self.__bases__,
+                              prepend + self.__bases__,
                               _no_slots_copy(self.__dict__),
                               tvars=tvars,
                               args=args,