Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stubs for attrs 19.3.0 #3900

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Update stubs for attrs 19.3.0 #3900

merged 1 commit into from
Apr 2, 2020

Conversation

euresti
Copy link
Contributor

@euresti euresti commented Apr 2, 2020 •
edited
Loading

Just syncing these from the attrs repo.

attr ships their stubs with the library. Would y'all recommend deleting these so we don't have to sync on every release or leaving them here?

@srittau
Copy link
Collaborator

srittau commented Apr 2, 2020

I don't see much point in keeping the stubs around here if upstream ships them. Cc @hynek

@euresti
Copy link
Contributor Author

euresti commented Apr 2, 2020

We've been discussing this here: python-attrs/attrs#480

@euresti
Copy link
Contributor Author

euresti commented Apr 2, 2020

My only reason for syncing them here is so that Pytype and Pyre still don't support PEP 561

srittau
srittau approved these changes Apr 2, 2020
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just glanced over those stubs, but found not red flags.

@srittau srittau merged commit 5f4ad2b into python:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@euresti @srittau