Make fieldnames of csv.DictReader Optional #3534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python docs specify that fieldnames can be set to None to use the first row of a CSV file as the fieldnames: https://docs.python.org/3.8/library/csv.html#csv.DictReader A git blame of CPython's source states it's been like that since Python 2.4, see https://github.com/python/cpython/blame/3.8/Lib/csv.py#L81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python docs specify that
fieldnamesincsv.DictReadercan be set toNoneto use thefirst row of a CSV file as the field names:
https://docs.python.org/3.8/library/csv.html#csv.DictReader
Therefore, this pull request changes
fieldnames: Sequence[str] = ...tofieldnames: Optional[Sequence[str]] = ....A
git blameof CPython's source states it's been likethat since Python 2.4,
see https://github.com/python/cpython/blame/3.8/Lib/csv.py#L81
I've also ran the file through
blackandisort(so that #3329 gets slightly easier), but I've put it into a separate commit, so it is easier to see the changes I made.Test Case