memoryview is a context manager #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
requested changes
Sep 11, 2018
stdlib/3/builtins.pyi
Outdated
| @@ -495,6 +495,8 @@ class memoryview(Sized, Container[int]): | |||
| ndim = ... # type: int | |||
|
|
|||
| def __init__(self, obj: Union[bytes, bytearray, memoryview]) -> None: ... | |||
| def __enter__(self) -> memoryview: ... | |||
| def __exit__(self, exc_type, exc_value, exc_tb) -> None: ... | |||
There was a problem hiding this comment.
Please annotate __exit__ with:
def __exit__(self, exc_type: Optional[Type[BaseException]], exc_val: Optional[BaseException], exc_tb: Optional[TracebackType]) -> bool: ...
Zac-HD
force-pushed
the
memoryview-contextmanager
branch
2 times, most recently
from
d5add1a
to
5d82e02
Compare
|
Thanks - and done! |
srittau
requested changes
Sep 11, 2018
stdlib/3/builtins.pyi
Outdated
| @@ -495,6 +495,8 @@ class memoryview(Sized, Container[int]): | |||
| ndim = ... # type: int | |||
|
|
|||
| def __init__(self, obj: Union[bytes, bytearray, memoryview]) -> None: ... | |||
| def __enter__(self) -> memoryview: ... | |||
| def __exit__(self, exc_type: Optional[BaseException], exc_val: Optional[BaseException], exc_tb: Optional[TracebackType]) -> bool: ... | |||
There was a problem hiding this comment.
exc_type should be Optional[Type[BaseException]].
There was a problem hiding this comment.
Wow, somehow I managed to drop the Type while copy-pasting and then manually deleted the extra brackets. Fixed now!
Since Python 3.2, __enter__ returns self and __exit__ calls self.release()
Zac-HD
force-pushed
the
memoryview-contextmanager
branch
from
5d82e02
to
0361dc1
Compare
srittau
approved these changes
Sep 11, 2018
|
Thank you! I will merge when the CI finishes successfully. |
|
Hurray! Thanks for the fast and helpful reviews 😍 |
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
Since Python 3.2, __enter__ returns self and __exit__ calls self.release()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Python 3.2,
memoryviewhas been usable as a context manager, so this PR adds the appropriate methods to let Mypy know. Found while working on python-trio/trio#543.