[python-jenkins] Improve get_jobs and get_all_jobs return type #14547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
donBarbos
reviewed
Aug 8, 2025
donBarbos
reviewed
Aug 8, 2025
| @@ -1,7 +1,7 @@ | |||
| from _typeshed import Incomplete | |||
| from collections.abc import Mapping, MutableMapping, Sequence | |||
| from re import Pattern | |||
| from typing import Any, Final, Literal, overload | |||
| from typing import Any, Final, Literal, TypedDict, overload | |||
There was a problem hiding this comment.
see above
Suggested change
| from typing import Any, Final, Literal, TypedDict, overload | |
| from typing import Any, Final, Literal, TypedDict, overload, type_check_only |
roberfi
force-pushed
the
python-jenkins-get-jobs
branch
from
844784f to
3c985d7
Compare
donBarbos
reviewed
Aug 8, 2025
| _class: str | ||
| url: str | ||
| color: str | ||
| name: str |
There was a problem hiding this comment.
Also fullname attribute was missing, moreover it seems required like name
but I can't say for sure that it is required :)
Suggested change
| name: str | |
| name: Required[str] | |
| fullname: Required[str] |
|
As a quick note, squash commits aren’t the recommended approach. |
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
brianschubert
approved these changes
Aug 8, 2025
Comment on lines
+98
to
+99
| url: str | ||
| color: str |
There was a problem hiding this comment.
Considering the docs say
Each job is a dictionary with ‘name’, ‘url’, ‘color’ and ‘fullname’ keys.
I think url and color can be made required as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14538