Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stubs for ijson #13462

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

add stubs for ijson #13462

wants to merge 15 commits into from

Conversation

DinhHuy2010
Copy link
Contributor

add stubs for ijson.

(disclaimer: I did not run the tests, yet.)

This comment has been minimized.

This comment has been minimized.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The only thing I noticed is that we now require each instance of Any to be commented with the possible types that could be used for Any.

@DinhHuy2010
Copy link
Contributor Author

Thanks! The only thing I noticed is that we now require each instance of Any to be commented with the possible types that could be used for Any.

Where is "Any" here?

@srittau
Copy link
Collaborator

srittau commented Feb 28, 2025

Several files use Any. If you are unsure about the types, you can replace Any with Incomplete (from _typeshed) for now.

This comment has been minimized.

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants