Mark typing.TYPE_CHECKING
as Final
#13180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per PEP 563,
typing.TYPE_CHECKING
is intended to be a constant. It seems sensible to annotate it as such.(Apparently some projects do modify it (e.g. sphinx autodoc temporarily sets it to
True
to help with import analysis), but that sort of use case seems dubious/exceptional enough to warrant a# type: ignore
.)