Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update caldav to 1.3.* #10485

Merged
merged 7 commits into from
Jul 20, 2023
Merged

Update caldav to 1.3.* #10485

merged 7 commits into from
Jul 20, 2023

Conversation

sobolevn
Copy link
Member

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@tobixen
Copy link

tobixen commented Jul 20, 2023

The 1.3 release seems to be cursed ... I suppose there will be a 1.3.7-release today as well

@tobixen
Copy link

tobixen commented Jul 20, 2023

Now that the caldav library officially does not work with python2 anymore ... perhaps we could get type hints merged into the library itself? I don't feel like prioritizing it myself, but I'd gladly accept merge/pull-requests.

@AlexWaygood
Copy link
Member

Now that the caldav library officially does not work with python2 anymore ... perhaps we could get type hints merged into the library itself? I don't feel like prioritizing it myself, but I'd gladly accept merge/pull-requests.

That would be fantastic. The pytype typechecker has a merge_pyi tool that can help with automatically integrating stubs into runtime packages. (Not promising to take this on myself either, though 😄)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 3a9b0c5 into main Jul 20, 2023
@AlexWaygood AlexWaygood deleted the caldav-1.3 branch July 20, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants