-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to pyperf 2.6.3 #330
Conversation
I am going to release 1.11.0 after this PR is merged. |
|
@mdboom @ericsnowcurrently Would you like to take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The only uncertainty I have is if this change could skew benchmark results in any meaningful way. If older results can no longer be compared with new results after this change (or if the skew must be accounted for) then at the least we'd want to be aware of that so we wouldn't be confused. That doesn't necessarily mean we shouldn't merge this though. 😄
I'd be interested to know what @mdboom thinks.
Thank you, Eric; from pyperf 2.6.2 to 2.6.3, there are only 2 changes.
So, the current default build-based benchmark will not be affected by these changes. |
Sound good. I'm satisfied. Thanks for explaining. |
See: python/cpython#116024
Except for coverge.py related benchmarks, pyperformance is runnable from a free-threaded build.
cc @colesbury