Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pyperf 2.6.3 #330

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Upgrade to pyperf 2.6.3 #330

merged 1 commit into from
Mar 8, 2024

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Mar 6, 2024

See: python/cpython#116024

Except for coverge.py related benchmarks, pyperformance is runnable from a free-threaded build.
cc @colesbury

@corona10 corona10 requested a review from mdboom March 6, 2024 15:24
@corona10
Copy link
Member Author

corona10 commented Mar 6, 2024

I am going to release 1.11.0 after this PR is merged.

@corona10
Copy link
Member Author

corona10 commented Mar 6, 2024

[ 1/87] 2to3...
# /Users/user/oss/foo/venv/cpython3.13-b3c68e7e7579-compat-a211859439da/bin/python -u /Users/user/oss/cpython/.venv/lib/python3.13/site-packages/pyperformance/data-files/benchmarks/bm_2to3/run_benchmark.py --output /var/folders/xf/8mmvc8hx4ld687g2bp49zmkw0000gn/T/tmp35jve2ds --inherit-environ PYPERFORMANCE_RUNID
Processing /Users/user/oss/cpython/.venv/lib/python3.13/site-packages/pyperformance/data-files/benchmarks/bm_2to3/vendor
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: lib2to3
  Building wheel for lib2to3 (pyproject.toml) ... done
  Created wheel for lib2to3: filename=lib2to3-3.12-py3-none-any.whl size=316110 sha256=8aabd67bca88aff2feca3cb24911afab35123161c09a24c59bff14abd41ea8ff
  Stored in directory: /private/var/folders/xf/8mmvc8hx4ld687g2bp49zmkw0000gn/T/pip-ephem-wheel-cache-deea6cdm/wheels/fa/2d/65/a45c8b749ba13b16f2223aac84f488631d07aeba421f4116ca
Successfully built lib2to3
Installing collected packages: lib2to3
Successfully installed lib2to3-3.12
.....................
2to3: Mean +- std dev: 291 ms +- 9 ms
[ 2/87] async_generators...
# /Users/user/oss/foo/venv/cpython3.13-b3c68e7e7579-compat-a211859439da/bin/python -u /Users/user/oss/cpython/.venv/lib/python3.13/site-packages/pyperformance/data-files/benchmarks/bm_async_generators/run_benchmark.py --output /var/folders/xf/8mmvc8hx4ld687g2bp49zmkw0000gn/T/tmp5u48eh0y --inherit-environ PYPERFORMANCE_RUNID
.....................
async_generators: Mean +- std dev: 435 ms +- 10 ms
[ 3/87] async_tree...
# /Users/user/oss/foo/venv/cpython3.13-b3c68e7e7579-compat-a211859439da/bin/python -u /Users/user/oss/cpython/.venv/lib/python3.13/site-packages/pyperformance/data-files/benchmarks/bm_async_tree/run_benchmark.py none --output /var/folders/xf/8mmvc8hx4ld687g2bp49zmkw0000gn/T/tmpie6ecfor --inherit-environ PYPERFORMANCE_RUNID
.....................
async_tree_none: Mean +- std dev: 296 ms +- 10 ms
[ 4/87] async_tree_cpu_io_mixed...
# /Users/user/oss/foo/venv/cpython3.13-b3c68e7e7579-compat-a211859439da/bin/python -u /Users/user/oss/cpython/.venv/lib/python3.13/site-packages/pyperformance/data-files/benchmarks/bm_async_tree/run_benchmark.py cpu_io_mixed --output /var/folders/xf/8mmvc8hx4ld687g2bp49zmkw0000gn/T/tmpplqkqqn9 --inherit-environ PYPERFORMANCE_RUNID
.....................
async_tree_cpu_io_mixed: Mean +- std dev: 581 ms +- 12 ms
[ 5/87] async_tree_cpu_io_mixed_tg...
# /Users/user/oss/foo/venv/cpython3.13-b3c68e7e7579-compat-a211859439da/bin/python -u /Users/user/oss/cpython/.venv/lib/python3.13/site-packages/pyperformance/data-files/benchmarks/bm_async_tree/run_benchmark.py cpu_io_mixed --task-groups --output /var/folders/xf/8mmvc8hx4ld687g2bp49zmkw0000gn/T/tmpiuxm_hrj --inherit-environ PYPERFORMANCE_RUNID
.....................
async_tree_cpu_io_mixed_tg: Mean +- std dev: 558 ms +- 17 ms
[ 6/87] async_tree_eager...
# /Users/user/oss/foo/venv/cpython3.13-b3c68e7e7579-compat-a211859439da/bin/python -u /Users/user/oss/cpython/.venv/lib/python3.13/site-packages/pyperformance/data-files/benchmarks/bm_async_tree/run_benchmark.py eager --output /var/folders/xf/8mmvc8hx4ld687g2bp49zmkw0000gn/T/tmpn43hsm0w --inherit-environ PYPERFORMANCE_RUNID
.....................
async_tree_eager: Mean +- std dev: 121 ms +- 2 ms
[ 7/87] async_tree_eager_cpu_io_mixed...
# /Users/user/oss/foo/venv/cpython3.13-b3c68e7e7579-compat-a211859439da/bin/python -u /Users/user/oss/cpython/.venv/lib/python3.13/site-packages/pyperformance/data-files/benchmarks/bm_async_tree/run_benchmark.py eager_cpu_io_mixed --output /var/folders/xf/8mmvc8hx4ld687g2bp49zmkw0000gn/T/tmpeg2x1dd3 --inherit-environ PYPERFORMANCE_RUNID
.....................
async_tree_eager_cpu_io_mixed: Mean +- std dev: 436 ms +- 11 ms
[ 8/87] async_tree_eager_cpu_io_mixed_tg...
# /Users/user/oss/foo/venv/cpython3.13-b3c68e7e7579-compat-a211859439da/bin/python -u /Users/user/oss/cpython/.venv/lib/python3.13/site-packages/pyperformance/data-files/benchmarks/bm_async_tree/run_benchmark.py eager_cpu_io_mixed --task-groups --output /var/folders/xf/8mmvc8hx4ld687g2bp49zmkw0000gn/T/tmpsdsn1xsw --inherit-environ PYPERFORMANCE_RUNID
.....................

@corona10
Copy link
Member Author

corona10 commented Mar 7, 2024

@mdboom @ericsnowcurrently Would you like to take a look?

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The only uncertainty I have is if this change could skew benchmark results in any meaningful way. If older results can no longer be compared with new results after this change (or if the skew must be accounted for) then at the least we'd want to be aware of that so we wouldn't be confused. That doesn't necessarily mean we shouldn't merge this though. 😄

I'd be interested to know what @mdboom thinks.

@corona10
Copy link
Member Author

corona10 commented Mar 8, 2024

The only uncertainty I have is if this change could skew benchmark results in any meaningful way. I

Thank you, Eric; from pyperf 2.6.2 to 2.6.3, there are only 2 changes.

So, the current default build-based benchmark will not be affected by these changes.
And I believe that an official benchmark comparison for free-threading should be handled when the free-threading build can execute pyperf without opt-out changes.

@ericsnowcurrently
Copy link
Member

Sound good. I'm satisfied. Thanks for explaining.

@corona10 corona10 merged commit 52a4c58 into python:main Mar 8, 2024
11 checks passed
@corona10 corona10 deleted the pyperf_263 branch March 8, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants