Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 734: Multiple Interpreters in the Stdlib #3523

Merged
merged 87 commits into from
Nov 28, 2023

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Nov 7, 2023

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

Standards Track requirements

  • PEP topic discussed in a suitable venue with general agreement that a PEP is appropriate
  • Suggested sections included (unless not applicable)
    • Motivation
    • Rationale
    • Specification
    • Backwards Compatibility
    • Security Implications
    • How to Teach This
    • Reference Implementation
    • Rejected Ideas
    • Open Issues
  • Python-Version set to valid (pre-beta) future Python version, if relevant
  • Any project stated in the PEP as supporting/endorsing/benefiting from the PEP formally confirmed such
  • Right before or after initial merging, PEP discussion thread created and linked to in Discussions-To and Post-History

📚 Documentation preview 📚: https://pep-previews--3523.org.readthedocs.build/pep-0734/

@ericsnowcurrently ericsnowcurrently changed the title PEP 734: PEP 734: Multiple Interpreters in the Stdlib Nov 7, 2023
peps/pep-0734.rst Outdated Show resolved Hide resolved
peps/pep-0734.rst Outdated Show resolved Hide resolved
peps/pep-0554.rst Show resolved Hide resolved
peps/pep-0554.rst Outdated Show resolved Hide resolved
peps/pep-0734.rst Outdated Show resolved Hide resolved
peps/pep-0734.rst Outdated Show resolved Hide resolved
peps/pep-0734.rst Outdated Show resolved Hide resolved
peps/pep-0734.rst Outdated Show resolved Hide resolved
peps/pep-0734.rst Outdated Show resolved Hide resolved
peps/pep-0734.rst Outdated Show resolved Hide resolved
peps/pep-0734.rst Outdated Show resolved Hide resolved
peps/pep-0734.rst Outdated Show resolved Hide resolved
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Eric, I know we already spoke about some of this off-line, but I ran out of time reviewing all my comments. I know the next revision will be much improved!

peps/pep-0734.rst Outdated Show resolved Hide resolved
peps/pep-0734.rst Outdated Show resolved Hide resolved
peps/pep-0734.rst Outdated Show resolved Hide resolved
peps/pep-0734.rst Outdated Show resolved Hide resolved
peps/pep-0734.rst Outdated Show resolved Hide resolved
peps/pep-0734.rst Outdated Show resolved Hide resolved
peps/pep-0734.rst Outdated Show resolved Hide resolved
peps/pep-0734.rst Outdated Show resolved Hide resolved
peps/pep-0734.rst Outdated Show resolved Hide resolved
peps/pep-0734.rst Outdated Show resolved Hide resolved
@ericsnowcurrently
Copy link
Member Author

@gvanrossum, I've made updates to address your review comments. Thanks again for taking the time to provide such useful feedback. ❤️

I'm concerned that the PEP is getting a little too long, so let me know if there are any sections that you think are unnecessary or have too much detail, if you can spare me the time.

@ericsnowcurrently
Copy link
Member Author

FYI, once this PR is merged, I plan on updating the implementation (and update some benchmarks, to try it out) before posting the PEP for discussion. That way I can tweak the PEP if something doesn't feel right in practice.

@gvanrossum
Copy link
Member

Are you awaiting more review from me? Im in Japan but can make a little time.

@ericsnowcurrently
Copy link
Member Author

Sweet of you to offer, but no. If needed, we can chat when you are back.

@ericsnowcurrently
Copy link
Member Author

There are probably a handful of things to tweak, like trim back some of the fluff, but I'll do that in follow-up PRs.

@ericsnowcurrently ericsnowcurrently merged commit 6aeaba7 into python:main Nov 28, 2023
@ericsnowcurrently ericsnowcurrently deleted the pep-554-rewrite branch November 28, 2023 02:32
@hugovk hugovk added the new-pep A new draft PEP submitted for initial review label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-pep A new draft PEP submitted for initial review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants