Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 729: Typing governance process #3455

Merged
merged 24 commits into from
Oct 4, 2023

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Sep 28, 2023

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

📚 Documentation preview 📚: https://pep-previews--3455.org.readthedocs.build/

@JelleZijlstra JelleZijlstra requested a review from a team as a code owner September 28, 2023 04:36
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! Some suggestions.

peps/pep-0729.rst Outdated Show resolved Hide resolved
peps/pep-0729.rst Outdated Show resolved Hide resolved
peps/pep-0729.rst Outdated Show resolved Hide resolved
peps/pep-0729.rst Show resolved Hide resolved
peps/pep-0729.rst Show resolved Hide resolved
peps/pep-0729.rst Outdated Show resolved Hide resolved
peps/pep-0729.rst Outdated Show resolved Hide resolved
peps/pep-0729.rst Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@hauntsaninja
Copy link
Contributor

Thanks for the review!

peps/pep-0729.rst Outdated Show resolved Hide resolved
JelleZijlstra and others added 2 commits September 28, 2023 06:26
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! I know I have been quiet lately, but I have been watching, and I am pleased with this proposal.

peps/pep-0729.rst Outdated Show resolved Hide resolved
peps/pep-0729.rst Outdated Show resolved Hide resolved
peps/pep-0729.rst Show resolved Hide resolved
peps/pep-0729.rst Outdated Show resolved Hide resolved
peps/pep-0729.rst Show resolved Hide resolved
peps/pep-0729.rst Show resolved Hide resolved
peps/pep-0729.rst Show resolved Hide resolved
peps/pep-0729.rst Outdated Show resolved Hide resolved
peps/pep-0729.rst Show resolved Hide resolved
peps/pep-0729.rst Outdated Show resolved Hide resolved
peps/pep-0729.rst Outdated Show resolved Hide resolved
@AA-Turner AA-Turner self-requested a review September 29, 2023 18:19
@JelleZijlstra JelleZijlstra merged commit 0e28ae9 into python:main Oct 4, 2023
@JelleZijlstra JelleZijlstra deleted the typing-council branch October 4, 2023 04:48
@JelleZijlstra JelleZijlstra restored the typing-council branch September 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants