Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Instruct linguist to include PEPs in the statistics #3430

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Sep 9, 2023

See https://github.com/github-linguist/linguist/blob/master/docs/overrides.md for context.

The updated 'languages' widget would look like:

image

A


📚 Documentation preview 📚: https://pep-previews--3430.org.readthedocs.build/

@AA-Turner AA-Turner changed the title Instruct linguist to include PEPs in the statistics Meta: Instruct linguist to include PEPs in the statistics Sep 9, 2023
@AA-Turner
Copy link
Member Author

Let's do this after #3418

@hugovk
Copy link
Member

hugovk commented Sep 9, 2023

Why isn't it detecting them already?

@AA-Turner
Copy link
Member Author

AA-Turner commented Sep 9, 2023

From https://github.com/github-linguist/linguist/blob/master/docs/overrides.md#detectable:

By default only languages of type programming or markup in languages.yml are included in the language statistics.

reStructuredText is defined as a prose type: https://github.com/github-linguist/linguist/blob/2fdbac7f8096c099be2b37a46b30a0fe6dfc415a/lib/linguist/languages.yml#L8188-L8203

A

@AA-Turner AA-Turner merged commit 233cd5e into python:main Sep 9, 2023
@AA-Turner AA-Turner deleted the gitattributes branch September 9, 2023 18:58
@AA-Turner
Copy link
Member Author

Before merge:

image

After merge:

image

A

@Rosuav
Copy link
Contributor

Rosuav commented Sep 9, 2023

That makes more sense. This SHOULD be a mostly-prose repository.

imgbot bot pushed a commit to hugovk/peps that referenced this pull request Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants