PEP 701: Syntactic formalization of f-strings #2907
Conversation
Co-authored-by: Batuhan Taskaya <isidentical@gmail.com> Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
|
CC: @lysnikolaou @isidentical 🚀 |
|
We need a PEP number and to update the discussion thread. |
|
You can take 701. A |
|
@isidentical We may want to add a section on how this can benefit tool authors as some people have reached out to us regarding this. |
|
@pablogsal Should we also update |
AA-Turner
changed the title
Please do, yes A |
AA-Turner
changed the title
There was a problem hiding this comment.
I did a light proofreading pass limited to fixing unambiguous typos, grammar errors and syntax/technical issues, all as one-click-applyable suggestions, plus a couple comments. I also provided suggestions to convert the PEP to use actual direct reST links for the URLs instead of indirect footnotes, per the guidance in #2130 and PEP 12.
Also, after applying the suggestions, the file extension needs to be changed to be .rst rather than .txt (I was wondering why the syntax highlighting wasn't working at all, heh).
Just FYI, we suggest always using the latest PEP template when creating your PEP, which helps avoid a lot of the issues here.
Finally, as a reminder (since even experienced core devs don't always remember it), you can directly apply some or all of the suggestions in just a few clicks by going to the Files changed tab, clicking Add to batch on the suggestions you want, then clicking Commit, saving both you and reviewers a lot of time and effort.
|
As a reminder (since even experienced core devs don't always remember it), you can directly apply some or all of the suggestions in just a few clicks by going to the |
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
|
@CAM-Gerlach Thanks for the thorough review! |
Of course! Thanks a lot! |
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
|
Merging this as we will iterate over the missing details in future PRs. Thanks everyone for your fantastic feedback and for making this document so much better. You all rock 🤘 |
|
Thanks @pablogsal ! In a bit of seemingly unintentionally perfect timing, I marked my one last comment as resolved to not block merge (since it could be addressed later, at the discretion of the PEP author) just moments before you were ready to merge it, heh, and had just completed one last source and output check a few seconds before. |
Co-authored-by: Batuhan Taskaya isidentical@gmail.com
Co-authored-by: Lysandros Nikolaou lisandrosnik@gmail.com