-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many PEPs: Rename to .rst
#2672
Conversation
Sorry for review request spam, I misclicked and opened as a live PR. A |
To note, this will require some linting changes (which I can help with). The If we move the PEPs, there will need to be some additional tweaks, some less mechanical but likely much less total time overall than this, and allow dropping the custom name filtering plugin and perhaps a few other bits of config. |
Also, just curious—in BrE, does "several" mean "hundreds"? To an AmE speaker, calling 440 PEPs "several" (as opposed to e.g. "Many") seems very odd indeed, but I know you Brits do things differently across the pond... |
Two dictionaries I tried defined 'several' as more than a few but fewer than many. American English is standard for Python. 'Rename multiple PEPs to .rst' might be even better. The committer ultimately decides on titles. |
Or better yet, Of course, that depends on what we decide on #10 ... |
What should we do about this PR? |
If this PR includes the changes mentioned by @CAM-Gerlach then I would suggest merging it. |
Unfortunately it doesn't; the move needs to be re-done, there are several more things that need to be dealt with regardless separately and don't depend on this PR but do block it (converting the remaining legacy-formatted author names and fixing instances of bad backticks), tweaking a few other things and also addressing the main delta from the general consensus on #10, which was to also move them into a I was going to start addressing the legacy-email formatting and backtick syntax issues in separate PRs (since those need to be fixed anyway and should be done first, to make the actual PEP that does the move as lean as possible). At that point we can then move ahead with this, either here or in a fresh PR. |
Since this is just going to potentially drift even farther out of sync with main I suggest we close it. |
Closing. Once the background work has been completed this can be revisited (or a new PR created). |
From #10, this is a less-invasive change of renaming to
pep-????.rst
but not moving directories.Moving directories could be done, but I'd prefer to reach a conclusion on the other thread first.
A