PEP 520: Fix citation references #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [nick_concern_] reference source was deleted in python@a9ed29c (python#35). Let's delete the redundant reference target to fix a Sphinx warning.
AA-Turner
reviewed
Jun 8, 2022
AA-Turner
reviewed
Jun 8, 2022
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner
approved these changes
Jun 8, 2022
AA-Turner
changed the title
ericsnowcurrently
requested changes
Jun 9, 2022
There was a problem hiding this comment.
Thanks for this update, @hugovk! I'm mostly fine. My only request is that you move the "nick_concern" entry into the new list instead of removing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The [nick_concern_] reference source was deleted in a9ed29c (#35).
Let's delete this orhpan to fix a Sphinx warning.
These were added in the very first commit (9a5e309) and were orphans from the start.
Let's convert them into a bullet list.
The final reference (to the implementation on BPO) doesn't cause a warning, but let's switch it into a direct hyperlink to GH (re: #2130).