Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 691: Copyright #2593

Merged
merged 3 commits into from
May 9, 2022
Merged

PEP 691: Copyright #2593

merged 3 commits into from
May 9, 2022

Conversation

dstufft
Copy link
Member

@dstufft dstufft commented May 8, 2022

  • Adds the Post History for Today
  • Adds a Copyright to the PEP

To merge this, we'll need permission from all the existing authors to copyright their work under the included license.

@dstufft
Copy link
Member Author

dstufft commented May 8, 2022

Hmm, I don't understand why that Lint job is failing, I think the Post-History header is in the format it's asking for?

@JelleZijlstra
Copy link
Member

Hmm, I don't understand why that Lint job is failing, I think the Post-History header is in the format it's asking for?

I think it's unhappy about the trailing /28. Since it's the same thread that's already listed, I don't think you need a new Post-History entry at all.

@dstufft
Copy link
Member Author

dstufft commented May 8, 2022

Okay

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(But don't merge until all the authors approve.)

@dstufft dstufft changed the title PEP 691: Copyright + Add Post History PEP 691: Copyright May 8, 2022
Copy link
Contributor

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CAM-Gerlach
Copy link
Member

I think it's unhappy about the trailing /28. Since it's the same thread that's already listed, I don't think you need a new Post-History entry at all.

Yeah, so long as its in the same thread, no need to link to multiple individual messages (I did have it allow that for mailing list posts, though, since there may sometimes be a need for it and its harder to do by accident, whereas with Discourse the /<messagenum> can get automatically appended and unintentionally link deep within a thread without that being necessarily obvious). Assuming we implement #2587 , future versions of the linter will be able to give much more specific feedback, and perhaps even automatically fix unintentionally-over-specific links links like this, but if this is a problem, I'm of course happy to update it now to allow it.

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dstufft ! And PR approvals with a message also indicating such seem to be a pretty solid strategy for documenting license acceptance, since they are relatively permanent (ish) and harder to mutate or "take back" compared to most other interactions.

We'll leave it to you to merge once @pradyunsg approves.

@CAM-Gerlach CAM-Gerlach requested a review from pradyunsg May 8, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants