Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 691: Draft PEP for Simple JSON API #2578

Merged
merged 7 commits into from
May 5, 2022
Merged

Conversation

di
Copy link
Member

@di di commented May 5, 2022

No description provided.

Co-authored-by: Cooper Lees <me@cooperlees.com>
Co-authored-by: Donald Stufft <donald@stufft.io>
Co-authored-by: Pradyun Gedam <pradyunsg@users.noreply.github.com>
@di di requested a review from a team as a code owner May 5, 2022 21:27
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented May 5, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

pep-9999.rst Outdated Show resolved Hide resolved
@di di changed the title PEP 9999: Draft PEP for Simple JSON API PEP 691: Draft PEP for Simple JSON API May 5, 2022
pep-0691.rst Outdated Show resolved Hide resolved
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on the PEP submission!

Can you also add a CODEOWNERS entry with @dstufft as the owner for this PEP?

pep-0691.rst Outdated Show resolved Hide resolved
pep-0691.rst Outdated Show resolved Hide resolved
di and others added 2 commits May 5, 2022 17:40
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
pep-0691.rst Outdated Show resolved Hide resolved
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
pep-0691.rst Outdated Show resolved Hide resolved
@JelleZijlstra JelleZijlstra merged commit 171c27e into python:main May 5, 2022
@di di deleted the simple-json branch May 5, 2022 22:29
@CAM-Gerlach CAM-Gerlach added the new-pep A new draft PEP submitted for initial review label May 6, 2022
@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented May 6, 2022

I'm very happy to hear that this new API is moving forward, and looking forward to seeing it implemented.

There are a handful of minor technical/rendering issues that can be fixed (inconsistent header order, obsolete BDFL-Delegate header, inconstant code-block syntax, incorrect syntax highlighting, dummy Discussions-To/Post-History, etc.), which I'm happy to help take care of.

However, there are two more critical problems that should be resolved as soon as you can (and we really should have spotted prior to merge), and block me making such changes:

  • The Copyright section required by PEP 1 is missing and should be added by an author of the PEP (such as yourself) with the concurrence of the others, in order to release its contents under a usable license.
  • While @dstufft is the SC-designated PEP-Delegate for PyPI infra, while he is allowed to also simultaneously be the PEP's Sponsor (given none of the others are core devs or PEP editors, IIRC), per PEP 1 he cannot simultaneously be PEP-Delegate and an author of the PEP (as that would be an obvious conflict of interest). Therefore, to resolve this, I would suggest he remove himself as an author of the PEP and serve as the PEP's sponsor instead (alternatively, he could recuse himself as the PEP-Delegate, or apply to the SC for a special exception if no one objected).

Also, while they are not strictly required and not as much a priority immediately, for the benefit of both reviewers and the community at large, you might to think about adding the relevant Suggested Sections from PEP 1, PEP 12 and the template, particularly "Security Implications", "Backwards Compatibility" and/or "Reference Implementation", and given the "answers" in the "FAQ" each closely fit the purpose of the standard "Rejected Ideas" section, I'd suggest retilting them accordingly.

As a final sidenote, there's no need to include a non-working dummy link for Discussions-To; as PEP 12 states, you should instead simply elide it when first submitting the PEP, and then just add it (and Post-History) immediately after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-pep A new draft PEP submitted for initial review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants