Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 642: Update status to Rejected #2547

Merged
merged 1 commit into from
Apr 24, 2022
Merged

PEP 642: Update status to Rejected #2547

merged 1 commit into from
Apr 24, 2022

Conversation

jeanas
Copy link
Contributor

@jeanas jeanas commented Apr 22, 2022

PEP 588, "GitHub Issues Migration Plan", is made Final since the
migration is done now.

PEP 642, "Explicit Pattern Syntax for Structural Pattern Matching",
has been rejected.

@CAM-Gerlach CAM-Gerlach changed the title Update two PEP statuses PEP 588, 642: Update statuses Apr 23, 2022
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm still sad that PEP 642 was rejected 😢

As for PEP 588 (and PEP 581, which should be updated at the same time), that's part of the discussion in #2497 ; these PEPs need to be updated to reflect the changes that occurred before and during implementation, so per PEP 1 marking them as Final should be part of that:

If changes based on implementation experience and user feedback are made to Standards track PEPs while in the Provisional or (with SC approval) Accepted state, they should be noted in the PEP, such that the PEP accurately describes the implementation at the point where it is marked Final.

Therefore, I suggest dropping the change to PEP 588 for now and letting that get resolved separately, and just keeping the one to PEP 642. Thanks!

@Mariatta any thoughts?

PEP 642, "Explicit Pattern Syntax for Structural Pattern Matching",
has been rejected.
@jeanas
Copy link
Contributor Author

jeanas commented Apr 23, 2022

Thank you for your feedback. I have updated this PR.

@CAM-Gerlach CAM-Gerlach changed the title PEP 588, 642: Update statuses PEP 642: Update statuses Apr 23, 2022
@CAM-Gerlach CAM-Gerlach changed the title PEP 642: Update statuses PEP 642: Update status to Rejected Apr 23, 2022
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks @jean-abou-samra

Leaving this for @ncoghlan to review, in case he wants to add a rejection notice or similar

@CAM-Gerlach CAM-Gerlach removed the request for review from Mariatta April 23, 2022 06:03
@ncoghlan
Copy link
Contributor

The link is fine as a reference for PEP 642's rejection (I honestly thought the state had been updated long ago - thanks for the catch!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants