Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 11: Add Linux s390x to Tier 3 #2543

Merged
merged 3 commits into from
Apr 25, 2022
Merged

PEP 11: Add Linux s390x to Tier 3 #2543

merged 3 commits into from
Apr 25, 2022

Conversation

vstinner
Copy link
Member

No description provided.

@vstinner
Copy link
Member Author

@brettcannon: I would like to support Linux s390x with Fedora Stable GCC. Did I pick the correct platform triple format? I wrote in the long python-committers thread, so it got lots in the discussion. So I write a PR to add it ;-)

In practice, I will likely also try to support all s390x buildbot workers:

  • Debian (GCC)
  • Fedora Rawhide (GCC)
  • Fedora Stable Clang
  • Fedora Rawhide Clang
  • RHEL7 (GCC)
  • RHEL8 (GCC)

And the LTO and LTO+PGO variants (Fedora Stable, Fedora Rawhide).

cc @encukou @tiran

pep-0011.txt Outdated
@@ -120,6 +120,7 @@ Target Triple Notes Buildbot
============================== =========================== ============================================== ========
aarch64-pc-windows-msvc https://buildbot.python.org/all/#/builders/729 Steve Dower
powerpcle-unknown-linux-gnu glibc, clang https://buildbot.python.org/all/#/builders/435 Victor Stinner
s390x-unknownlinux-gnu glibc, gcc https://buildbot.python.org/all/#/builders/223 Victor Stinner
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
s390x-unknownlinux-gnu glibc, gcc https://buildbot.python.org/all/#/builders/223 Victor Stinner
s390x-unknown-linux-gnu glibc, gcc https://buildbot.python.org/all/#/builders/223 Victor Stinner

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so when I copy/paste an example, I pick the only one with a typo :-D I fixed the typo in the s390x platform, but also on the x86_64-unknownlinux-gnu platform.

@brettcannon
Copy link
Member

You will need to ask the SC as the PR was what we reviewed and approved.

@vstinner
Copy link
Member Author

You will need to ask the SC as the PR was what we reviewed and approved.

I created python/steering-council#122 to ask the SC. I convert this PR to a draft to make sure that it's not merged by mistake.

@vstinner vstinner marked this pull request as draft April 20, 2022 22:19
@vstinner vstinner marked this pull request as ready for review April 25, 2022 21:58
@vstinner
Copy link
Member Author

The SC agrees with this addition, SC decision: python/steering-council#122 (comment)

@vstinner vstinner merged commit 4233ef7 into python:main Apr 25, 2022
@vstinner vstinner deleted the pep11_s390x branch April 25, 2022 22:01
@vstinner
Copy link
Member Author

Merged. Thanks @brettcannon for the review (I fixed the platform format ;-)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants