Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 517: add missing def for the mandatory hook build_wheel signature #2535

Merged
merged 2 commits into from
Apr 19, 2022
Merged

PEP 517: add missing def for the mandatory hook build_wheel signature #2535

merged 2 commits into from
Apr 19, 2022

Conversation

wimglenn
Copy link
Contributor

All the other example hooks have a def so this looks like a typo.

@wimglenn wimglenn requested a review from njsmith as a code owner April 18, 2022 02:05
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Apr 18, 2022 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

CAM-Gerlach
CAM-Gerlach approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@brettcannon brettcannon merged commit 07b9d0c into python:main Apr 19, 2022
@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@njsmith njsmith Awaiting requested review from njsmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wimglenn @brettcannon @CAM-Gerlach