Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: Reduce space consumed by headers and improve alignment #2533

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

CAM-Gerlach
Copy link
Member

As discussed on #2514 , the headers at the top consume excessive vertical space, particularly on mobile which some style tweaks could dramatically improve with no loss of information. Furthermore, there are some odd gaps and spacing between the various elements that could be fixed, and the title and PEP number is redundant and can be removed, as it is present no less than four other places (the main title, the breadcrumbs, the sidebar [as addressed by #2532], and the tab title).

To note, while it is included in the comparisons below, this PR defers the implementation of removing or abbr-ing the email address to a followup PR, as it may require a bit more discussion and is better done after #2484 is merged.

Desktop (Before/After)

image

Mobile (Before/Previous/Latest)

image

Fixes #2514

@CAM-Gerlach CAM-Gerlach added the infra Core infrastructure for building and rendering PEPs label Apr 16, 2022
@CAM-Gerlach CAM-Gerlach requested review from hugovk and a team April 16, 2022 11:55
@CAM-Gerlach CAM-Gerlach self-assigned this Apr 16, 2022
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked on desktop (Mac, Chrome) and mobile (Samsung S10, Chrome) and looks good.

I'm mindful we shouldn't be squashing things too tightly together, but this is fine.

Thanks!

@hugovk
Copy link
Member

hugovk commented Apr 19, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Core infrastructure for building and rendering PEPs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Waste less vertical space at top of rendered PEP
2 participants