Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 670: Mark as Accepted #2522

Merged
merged 3 commits into from
Apr 15, 2022
Merged

PEP 670: Mark as Accepted #2522

merged 3 commits into from
Apr 15, 2022

Conversation

erlend-aasland
Copy link
Contributor

No description provided.

@erlend-aasland
Copy link
Contributor Author

cc. @encukou

@encukou
Copy link
Member

encukou commented Apr 13, 2022

I noticed Post-History is missing. Do you happen to have the discussion thread links handy?

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 13, 2022 •
edited
Loading

I noticed Post-History is missing. Do you happen to have the discussion thread links handy?

Here's some links to recent discussion. There are also some older discussions; let me know if I should find links to them.

How should I add them? One Post-History header for each, one header with all links on one line? Found out from looking at #2521 :)

UPDATE: Added in 7ab1777

CAM-Gerlach
CAM-Gerlach requested changes Apr 15, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some syntax and format issues, otherwise LGTM

pep-0670.rst Outdated Show resolved Hide resolved
@CAM-Gerlach
Update pep-0670.rst
bebc95b 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
CAM-Gerlach
CAM-Gerlach approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @erlend-aasland !

@CAM-Gerlach CAM-Gerlach merged commit 0666a97 into python:main Apr 15, 2022
@erlend-aasland erlend-aasland deleted the pep670/accepted branch April 15, 2022 23:26
@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @encukou @JelleZijlstra @CAM-Gerlach