Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 681: Fix header links #2507

Merged
merged 2 commits into from
Apr 16, 2022
Merged

PEP 681: Fix header links #2507

merged 2 commits into from
Apr 16, 2022

Conversation

JelleZijlstra
Copy link
Member

#2481 didn't like the hashes in the URLs

#2481 didn't like the hashes in the URLs
@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Apr 16, 2022

Thanks; I've instead updated #2484 to ensure URL fragments are allowed (e.g. skipping to specific posts, as these are); there's no real harm in doing so and it avoids extra work/frustration from authors having to manually trim them. Therefore, this PR isn't really needed any more, unless you/the author don't want to explicitly jump to the specific messages in the thread.

@JelleZijlstra
Copy link
Member Author

Since it's the top message in the thread, I feel like it's nicer to link to the whole thread.

@CAM-Gerlach
Copy link
Member

Yeah, I agree, and upon closer inspection and visiting the links I see the second one actually appears to link to the wrong message (for me in FF on Windows, my browser doesn't actually jump to it when I first visit the page, only when I press enter again on the link with the page loaded—perhaps Hyperkitty has an issue with its JS triggers.

@CAM-Gerlach CAM-Gerlach added the lint Linter-related work and linting fixes on PEPs label Apr 16, 2022
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @JelleZijlstra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed lint Linter-related work and linting fixes on PEPs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants