Style: Fix unbounded max width causing very wide spans to overflow #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
approved these changes
Mar 29, 2022
|
It's been two days and this was approved, so going ahead and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As originally reported by @pradyunsg on #2476 , PEP 440 (PEP-0440, namely this section) and possibly other specific PEPs that contain very long
<span>s (i.e. syntax-highlighted text with the same color) inside scrolling literal blocks overflow the viewport at wider screen width, causing the rest of the page to overflow as well.To make a long story short, after some investigation and testing, setting an appropriately-bounded
max-widthon the page content for the widest breakpoint (where it was previously unbounded) avoided this problem and ensured the page displayed identically to other PEPs with more typical content, while not affecting anything else.Additionally, I noticed that
max-widthfor the next-narrower breakpoint was not quite set correctly, leading to a modest overflow at widths near the breakpoint, which I fixed as well.Fixes #2476