-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 681: Rename transform_descriptor_types to delete_class_attributes #2455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code formatting on True
/ False
:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from one nit.
Should I merge this? After we merge it, I can provide a new typing-extensions release with the new behavior.
I regret holding things up when everyone else seems satisfied, but I really don't think Also, after exploring the current runtime behavior of I'll elaborate on the existing mailing list thread, since that's where the design discussion has taken place so far. |
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Abandoning this PR in favor of #2477 |
We decided to rename
transform_descriptor_types
todelete_class_attributes
because:Renamed the parameter and added a new section describing the behavior in more detail.
Also removed the line about Django limitations making
dataclass_transform
usage impractical, since we've gotten user feedback that that's not the case. I can create a separate PR for this if preferred.cc: @carljm @erictraut