PEP 686: Update URLs, PEP references, Discussions-To and CODEOWNERS per PEP 12 #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical-only updates to PEP 686 (PEP-0686) per PEP 12 (PEP-0012):
:pep:role instead of hardcoded PEP URLs (the checkers are supposed to catch this, but I was still in the process of updating it to check for the new URL format; I'll have that very shortly)Discussions-ToandPost-Historyheaders now that the thread is live (it should be updated whenever a new discussion thread for the PEP is posted, so people know where to go to give feedback)CODEOWNERS@methane in the process, I also noticed some grammar issues in the PEP, but I refrained from changing the text here. If you'd like me to follow up with another PR for your review addressing them, to help make the PEP easier for others to read and understand clearly, I would be happy to. Just let me know; it is up to you as the author of the PEP.