Accessibility: Add aria-label to clearly describe the dark mode button

[hugovk]

1. Go to https://web.dev/measure/
2. Enter https://peps.python.org/ and RUN AUDIT

(Alternatively, Chrome devtools has a Lighthouse tab to run the same thing.)

Before

https://peps.python.org/

Buttons do not have an accessible name
When a button doesn't have an accessible name, screen readers announce it as "button", making it unusable for users who rely on screen readers. Learn more.

https://web.dev/button-name/?utm_source=lighthouse&utm_medium=lr says:

For buttons without visible labels, like icon buttons, use the aria-label attribute to clearly describe the action to anyone using an assistive technology [...]

After

https://pep-previews--2426.org.readthedocs.build/

(There are of course further manual accessibility things that can be checked.)

[CAM-Gerlach]

LGTM, thanks @hugovk

[hugovk]

@raghavthind2005 Thank you for the review.

I see you've been leaving lots of reviews lately, 36 over the the past two days:

In general, reviews are definitely appreciated! However, when they're approvals on PRs which have already been approved, often by a core developer (as all the ones I checked have been), they're a bit more noisy and distracting than useful and look a bit more like spam.

As you're pretty new, it may be more helpful to instead review things which haven't already been approved, and give a comment as to why you approve or disapprove (not just "LGTM").

Other things that would be more helpful: there are a number of "easy" issues you can tackle, see https://devguide.python.org/fixingissues/.

Thanks!

[AlexWaygood]

@hugovk, I think @raghavthind2005 doesn't really deserve the benefit of the doubt anymore. Over the past few months, it's been pointed out to them multiple times in the CPython repo, by several different core devs, that this behaviour isn't particularly helpful. As far as I know, they haven't responded once. They also now appear to be starting to spam other repos in a similar way

[hugovk]

Yes, 36 reviews in seven Python repos and two Microsoft over the past two days (see screenshot above).

[hugovk]

Over the past few months, it's been pointed out to them multiple times in the CPython repo, by several different core devs, that this behaviour isn't particularly helpful. As far as I know, they haven't responded once.

Here's a few, no response:

• 23 Jan: [3.9] bpo-21987: Fix TarFile.getmember getting a dir with a trailing slash (GH-30283) cpython#30738 (comment)
• 30 Jan: bpo-46198: rename duplicate tests and remove unused code cpython#30297 (comment)
• 31 Jan: bpo-44031: fix test_tabnanny failure in non-ascii CWD cpython#31014 (comment)
• 8 Feb: [3.9] bpo-46436: Fix command-line option -d/--directory in module http.server (GH-30701) cpython#31103 (comment)

Plus mention in a python-dev thread about spam activity:

• https://mail.python.org/archives/list/python-dev@python.org/message/UO6ZSNWLLXWU7AZ7NGQDTOQ2WVX2ZAZN/

[AlexWaygood]

These are the PRs they reviewed nearly simultaneously in the mypy repo this morning:

• Fix @dataclass to catch default / non-default fields order mypy#12159 (review)
• stubgen: fixed handling of Protocol and added testcase mypy#12129 (review)
• Speed up ArgKind methods by changing them into top-level functions mypy#11546 (comment)

[CAM-Gerlach]

@hugovk @AlexWaygood I've also noticed and investigated a lot of spam/bot accounts lately that match this pattern, including several on this repo very recently as well as on other larger repos I maintain, leaving approving reviews typically on merged PRs on larger/more popular repos with either no content, just a link to the same PR, or random characters, with zero interaction with other users and little to no other activity. In a lot of cases, they have a link in their profile, and occasionally on their messages, that they seem to be driving traffic/inbounds (i.e. PageRank) towards, but in other cases, they just seem to be building up the account's inbounds, contributions, etc. presumably in preparation for selling the account or whatever their endgame is.

In this case, since they don't (yet) have such a link on their profile and their pattern doesn't quite match others, there's a very slim chance that they're really who they say they are in their description (a high school student) trying to rack up karma either for personal pride, to build up their contribution numbers (perhaps for an application to something) or for some other purpose, and who simply doesn't care that what they are doing is disruptive, meaningless and wrong. But at this point, after being called out over and over, even in the small change this isn't the case they are clearly beyond reasoning with, so I suggest just reporting them on their profile, preferably with links to the instances and the Python-Dev thread, (since approvals cannot be reported, unlike comments) and moving on.

[CAM-Gerlach]

FYI, here is the report I filed.

Rendered Report

This user has been spamming dozens of drive-by approval reviews with no content on various (merged and unmerged) PRs in the repositories of the Python organization, including cpython, mypy and peps (which I maintain). This has caused significant disruption, as it pings everyone involved with the PR and everyone watching the repo, spuriously marks the PR as approved, interferes with our bot tagging, and leads to other users trying to explain to them why they shouldn't do that, to which the user never responds and just continues the behavior. Unfortunately, since they are just approvals without comments, or on merged PRs, they cannot be dismissed and cannot be reported, which is perhaps the purpose of the tactic. This has led, in part, to a whole thread on the Python-Dev list about this behavior, and a lengthy discussion on python/peps#2426.

Here are a few examples of python/cpython PRs on which the user did the behavior, it was explained to them why they shouldn't, and they never responded and continued instead:

• 23 Jan: [3.9] bpo-21987: Fix TarFile.getmember getting a dir with a trailing slash (GH-30283) cpython#30738 (comment)
• 30 Jan: bpo-46198: rename duplicate tests and remove unused code cpython#30297 (comment)
• 31 Jan: bpo-44031: fix test_tabnanny failure in non-ascii CWD cpython#31014 (comment)
• 8 Feb: [3.9] bpo-46436: Fix command-line option -d/--directory in module http.server (GH-30701) cpython#31103 (comment)

And here are a few they opened on cpython/mypy just this morning:

• Fix @dataclass to catch default / non-default fields order mypy#12159 (review)
• stubgen: fixed handling of Protocol and added testcase mypy#12129 (review)
• Speed up ArgKind methods by changing them into top-level functions mypy#11546 (comment)

Thanks.

Source Text

This user has been spamming dozens of drive-by approval reviews with no content on various (merged and unmerged) PRs in the repositories of the Python organization, including `cpython`, `mypy` and `peps` (which I maintain). This has caused significant disruption, as it pings everyone involved with the PR and everyone watching the repo, spuriously marks the PR as approved, interferes with our bot tagging, and leads to other users trying to explain to them why they shouldn't do that, to which the user never responds and just continues the behavior. Unfortunately, since they are just approvals without comments, or on merged PRs, they cannot be dismissed and cannot be reported, which is perhaps the purpose of the tactic. This has led, in part, to a [whole thread on the Python-Dev](https://mail.python.org/archives/list/python-dev@python.org/message/UO6ZSNWLLXWU7AZ7NGQDTOQ2WVX2ZAZN/) list about this behavior, and a lengthy discussion on [python/peps#2426](https://github.com/python/peps/pull/2426).

Here are a few examples of python/cpython PRs on which the user did the behavior, it was explained to them why they shouldn't, and they never responded and continued instead:

* 23 Jan: https://github.com/python/cpython/pull/30738#issuecomment-1019388000
* 30 Jan: https://github.com/python/cpython/pull/30297#issuecomment-1025235319
* 31 Jan: https://github.com/python/cpython/pull/31014#issuecomment-1025944292
* 8 Feb: https://github.com/python/cpython/pull/31103#issuecomment-1032714555

And here are a few they opened on cpython/mypy just this morning:

- https://github.com/python/mypy/pull/12159#pullrequestreview-910122475
- https://github.com/python/mypy/pull/12129#pullrequestreview-910122911
- https://github.com/python/mypy/pull/11546#issuecomment-1067932649

Thanks.

[hugovk]

Nine more today. I've also filed a report.

@raghavthind2005, please stop.

[CAM-Gerlach]

Nine more today. I've also filed a report.

Thanks; I encourage any other responsible parties on repos this affects to do the same, as unfortunately it is likely the only way to put a stop to the behavior at this point