Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 675: Establish typing context in the Abstract #2324

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

encukou
Copy link
Member

@encukou encukou commented Feb 14, 2022

The document was drafted and discussed on typing-sig, which is perfectly acceptable for this PEP.
But as a general PEP, it should briefly establish its context.

(The PR just adds Using static type annotations,, splits a sentence that becomes too long, and adjusts capitalization.)

The document was drafted and discussed on typing-sig, which is perfectly acceptable for this PEP.
But as a general PEP, it should briefly establish its context.
@AA-Turner AA-Turner changed the title Establish typing context in the Abstract PEP 675: Establish typing context in the Abstract Feb 14, 2022
@AA-Turner
Copy link
Member

Thanks!
A

@AA-Turner AA-Turner merged commit ba2a929 into main Feb 15, 2022
@AA-Turner AA-Turner deleted the encukou-pep-685-patch-1 branch February 15, 2022 01:14
@JelleZijlstra
Copy link
Member

cc @pradeep90

@AA-Turner
Copy link
Member

@JelleZijlstra sorry if I merged this too early! I'd seen other activity of yours & assumed you'd seen this.
A

@JelleZijlstra
Copy link
Member

Yes, I hadn't gotten to this one yet. Better to wait for the PEP author to approve in general, though this change is pretty harmless.

@AA-Turner
Copy link
Member

I tend to wait for approval generally but had thought this one was small enough to merge -- will bear in mind for future, sorry.

A

@pradeep90
Copy link
Contributor

Yes, we'd have appreciated a heads-up. We would not have known about this change otherwise :)

cc @gbleaney

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants