Remove needless gender specific terms. #855 #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup grating unmodern gender wording text in old PEPs that were pointed out in python#855.
|
IMO this is unnecessary churn. |
gvanrossum
reviewed
Jan 22, 2022
| @@ -115,7 +115,7 @@ documentation for the ABC. These standard semantic definitions are | |||
| not enforced, but are strongly recommended. | |||
|
|
|||
| Like all other things in Python, these promises are in the nature of a | |||
| gentlemen's agreement, which in this case means that while the | |||
| friendly agreement, which in this case means that while the | |||
There was a problem hiding this comment.
Hmm, that could work, albeit with a bit of rewriting. Retaining "agreement" as the second word would be more of a drop-in replacement, though perhaps "understanding" is more what you intend here? As for the first word, perhaps "non-binding" or "informal" better capture the desired meaning? Up to you.
There was a problem hiding this comment.
I had informal agreement in my head too.
There was a problem hiding this comment.
I had
informal agreementin my head too.
That's probably the closest match for the original word, for what its worth
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup grating unmodern gender wording text in old PEPs that were pointed out
in #855.