Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 674: Address Tim Felgentreff's review #2249

Merged
merged 3 commits into from
Jan 19, 2022
Merged

PEP 674: Address Tim Felgentreff's review #2249

merged 3 commits into from
Jan 19, 2022

Conversation

vstinner
Copy link
Member

No description provided.

@vstinner vstinner mentioned this pull request Jan 18, 2022
Merged
@vstinner
Copy link
Member Author

@timfel: Would you mind to review it?

CAM-Gerlach
CAM-Gerlach reviewed Jan 18, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny suggestions

pep-0674.rst Outdated Show resolved Hide resolved
pep-0674.rst Outdated Show resolved Hide resolved
@timfel
Copy link
Contributor

timfel commented Jan 19, 2022

@timfel: Would you mind to review it?

Thanks, looking good :)

vstinner and others added 2 commits January 19, 2022 11:19
@vstinner @CAM-Gerlach
Update pep-0674.rst
16c70bf 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@vstinner @CAM-Gerlach
Update pep-0674.rst
8f772ea 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@vstinner vstinner merged commit 8388db2 into python:main Jan 19, 2022
@vstinner
Copy link
Member Author

Ok, merged ;-)

@vstinner vstinner deleted the pep674_timfel branch January 19, 2022 10:22
@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @timfel @CAM-Gerlach @the-knights-who-say-ni