Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 613: Loosen class scope restriction of explicit TypeAlias #2154

Merged
merged 2 commits into from
Jan 12, 2022

Conversation

nipunn1313
Copy link
Contributor

@gvanrossum
Copy link
Member

gvanrossum commented Nov 17, 2021

As long as the conversation on typing-sig is still open I think we should leave this. Maybe change to Draft?

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I believe both pyre and pyright developers spoke up on typing-sig and approved of this idea.

I would recommend waiting a few days to land this, because it's possible that everyone will agree to relaxing things even more to the point where type aliases are also allowed inside functions. Then the whole scope restriction section could be struck.

@nipunn1313
Copy link
Contributor Author

I created #2158 - which I think we should prefer to this option.
Put up both PRs to have something concrete to discuss around. Will continue (finalize?) discussion on typing-sig

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure if this PR is still relevant, but I spotted a few minor grammar/typo issues in the added/changed content

pep-0613.rst Outdated Show resolved Hide resolved
pep-0613.rst Outdated Show resolved Hide resolved
@gvanrossum
Copy link
Member

Not 100% sure if this PR is still relevant, but I spotted a few minor grammar/typo issues in the added/changed content

I think this one deserves to be merged, given that (a) it's small and focused, (b) typing-sig folks agreed, and (c) this PEP is still young.

CAM, do you have merge permissions on this repo? If not, at-mention me when it's ready to be merged.

Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@nipunn1313
Copy link
Contributor Author

Thanks for the review!

@CAM-Gerlach
Copy link
Member

@nipunn1313 You're most welcome!

@gvanrossum 🔔 🔔 🔔

CAM, do you have merge permissions on this repo? If not, at-mention me when it's ready to be merged.

No; I'm not a PEP editor, remember? 😆

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @nipunn1313 !

@gvanrossum gvanrossum merged commit 3ec824a into python:main Jan 12, 2022
@gvanrossum
Copy link
Member

CAM, do you want to be a PEP editor? You could replace Chris A (who's no longer active AFAICT).

@Rosuav
Copy link
Contributor

Rosuav commented Jan 12, 2022

I kinda stepped back a bit after the dumpster fire of PEP 671. Would support CAM as a PEP editor, with or without me stepping down.

@JelleZijlstra
Copy link
Member

I posted on https://github.com/orgs/python/teams/pep-editors the other day but clearly that's not an effective communication mechanism :)

@gvanrossum
Copy link
Member

I posted on https://github.com/orgs/python/teams/pep-editors the other day but clearly that's not an effective communication mechanism :)

Indeed it is not. I received no notification. Let's move the discussion there though now that I've been alerted.

@gvanrossum
Copy link
Member

Indeed it is not. I received no notification. Let's move the discussion there though now that I've been alerted.

(I figured it out. You have to watch the team. It's in the left sidebar of the team UI.)

@CAM-Gerlach
Copy link
Member

I didn't want to derail this issue and wasn't sure if I should wait on being notified of the result of the mentioned private discussion before prematurely responding, but given some time has passed, I figured I'd reply for the record.

Wow, thanks @gvanrossum ! I am positively flattered that you'd ask, and would certainly be excited to join the PEP editor team, provided you all are okay with it. While I do have a background in this elsewhere, I know it is a significant step up in trust and responsibility for someone who hasn't been contributing for that long on this particular repo, and who isn't as much of a "known quantity" around here as perhaps others are (not to mention, I'm a bit of a "small fry" overall compared to all of you, heh). As such, I totally understand if anyone has reservations about going ahead with it for now, and would of course be happy to continue helping out with proofreading, formatting, copyediting and maintenance in the ways I can as a regular contributor if so. However, if you are all on board with it, then I'd be honored to officially join your number. Just let me know!

Some general background about me, for anyone curious:

  • I'm a 26-year-old NASA atmospheric science researcher and Ph.D student in Huntsville, AL, USA (originally from Northern Virginia/near Washington DC)
  • My full legal name is Christopher Aaron Manning Gerlach, go by CAM (from my initials), and my current pronouns are he/him/his
  • A few selected recent areas of relevant interest in Python for me include:
    • Scientific Python/PyData/data science (since I'm an atmospheric science researcher by trade)
    • Packaging (which my experience re-writing and championing PEP 639 has been very valuable in getting me familiar with)
    • Code analysis/static typing (for which I've contributed a bit to @JelleZijlstra 's excellent PyAnalyze project).
  • I'm the maintainer or co-maintainer of a handful of repos of various sizes, including QtPy, docrepr, Spyder, particularly its docs, website and theme, the SPDX FSF-API and Pyroma, along with my own projects like the Mjolnir system, Sub Manager and glML, and websites for various organizations.
  • I have strong interests and past experience in copyediting, technical writing, documentation, Sphinx/RST syntax and style, etc.
  • I've held a fairly similar role for several years now as the primary editor, maintainer and standards/style guide writer/implementer on the Sphinx/RST docs, website, etc of the Spyder project
  • I've done past work (paid and volunteer) as a technical/science writer, copyeditor, grant writer/reviewer, and website copywriter.
  • I am an avid consumer of PEP of all sorts, which I enjoy reading including in my leisure time
  • I'm current primary author of PEP 639, and have participated in discussing, copyediting and helping advocate for a handful of others (e.g. PEP 597, PEP 676, PEP 680, forthcoming PEPs on extras names and requires_python)
  • I've contributed various small bits to the CIs, pre-commit and build system (legacy and Sphinx) of this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants