Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 639: Update the metadata version to 2.3 as 2.2 already exists #2140

Closed
wants to merge 1 commit into from

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Nov 11, 2021

No description provided.

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting started on this! Its 100% my fault for not editing my comment (and for not doing it in the first place), but per @pfmoore 's response, that is actually the one part that I was mistaken about, and instead all the references to the metadata version should be removed instead and the PEP reformatted to look like PEP 643. I'll mention that in a review and drop a PR shortly 🤞 doing that instead. But thanks again for getting things moving!

@CAM-Gerlach
Copy link
Member

Quick update: My PR is almost ready, at least 3/4ths done as of tonight, and I hope to finish and submit sometime tomorrow. To note, aside from the fact that @pfmoore requested a different approach from that here (as I've implemented), it will make for major merge conflicts with my work, so let's make sure not to merge this one, okay? :) My work is on a branch on my fork, in case anyone wants to take an early sneak peek.

Side note: Given pretty much all the significant content changes were already discussed/agreed on the Discuss thread, but on the other hand it is a pretty comprehensive overhaul, should I submit it as a PR once its ready and invite the Discuss thread followers to review it, or link my branch in the Discuss thread for feedback before submitting here?

@hroncok hroncok closed this Nov 18, 2021
@ofek
Copy link
Contributor

ofek commented Nov 18, 2021

@CAM-Gerlach I'd open a PR 👍

@CAM-Gerlach
Copy link
Member

Will do, thanks, sounds like that's what Paul suggested on the Discuss thread a while back too. Got stuck with a big GitHub backlog at the moment but will try to finish by later tonight.

@CAM-Gerlach
Copy link
Member

Opened as #2164 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants