Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 673: Initial commit for Self Types. #2139

Merged
merged 2 commits into from
Nov 11, 2021
Merged

PEP 673: Initial commit for Self Types. #2139

merged 2 commits into from
Nov 11, 2021

Conversation

pradeep90
Copy link
Contributor

Format text and code to fit within 79 characters.

cc @Gobot1234

@pradeep90 pradeep90 requested a review from a team as a code owner November 11, 2021 03:49
@JelleZijlstra
Copy link
Member

There are a couple of RST problems in CI.

@pradeep90
PEP 673: Initial commit for Self Types.
db8ebb6 
Format text and code to fit within 79 characters.

Address rST errors.
@pradeep90
Copy link
Contributor Author

There are a couple of RST problems in CI.

I've fixed and pushed. Could you approve again so that the CI workflows are rerun? Thanks.

@pradeep90
PEP 673: Inline reference links.
8e55187 
This follows Guido's suggestion in python#2130.
@JelleZijlstra JelleZijlstra merged commit 6df0c1d into python:master Nov 11, 2021
@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pradeep90 @JelleZijlstra @the-knights-who-say-ni