Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 8: Removed references to Python 2 #2059

Merged
merged 10 commits into from
Sep 1, 2021
Merged

Conversation

PythonCHB
Copy link
Contributor

After a brief discussion on python-dev, I've removed all references to Python 2 in PEP 8.

(https://mail.python.org/archives/list/python-dev@python.org/thread/MK7N36L3XCXVY5R4DIIYIDU2W7EGJKZ3/)

There are a few items I'm not totally sure about -- see line by line comments.

Also, it was suggested that we might want to put a note in for folks indicating that they can find Python2 relevant versions in the history. I don't think that necessary, but if anyone else wants to add that, of course they can.

Copy link
Contributor Author

@PythonCHB PythonCHB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes on things I wasn't sure about.

pep-0008.txt Show resolved Hide resolved
pep-0008.txt Outdated Show resolved Hide resolved
pep-0008.txt Show resolved Hide resolved
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo and formatting

pep-0008.txt Outdated Show resolved Hide resolved
pep-0008.txt Show resolved Hide resolved
@gvanrossum
Copy link
Member

I'll let you all come to a conclusion, and then as the nominal PEP's author I'd like to have the final say. (I'll ask Barry too.)

@PythonCHB
Copy link
Contributor Author

@gvanrossum, @warsaw:

I"m not sure if you want anyone else to review, but I believe I've responded to all comments so far.

I think it's ready.

pep-0008.txt Outdated Show resolved Hide resolved
pep-0008.txt Outdated Show resolved Hide resolved
@ambv
Copy link
Contributor

ambv commented Aug 27, 2021

Two nits from me, otherwise LGTM.

@smontanaro
Copy link
Contributor

Before removing all Python 2 references from PEP 8, I suggest a tag or branch be created with a meaningful name, something like "lastpy2pep8". It should be a one-and-done sorry of thing and make it easier for people still maintaining tools which support Python 2 (such as the pep8 app in PyPI) to refer to (or to publish).

pep-0008.txt Show resolved Hide resolved
pep-0008.txt Outdated Show resolved Hide resolved
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am totally cool with this! Will land now, since it's been quiet here for a while.

@gvanrossum gvanrossum merged commit 434a032 into python:master Sep 1, 2021
@gvanrossum
Copy link
Member

Before removing all Python 2 references from PEP 8, I suggest a tag or branch be created with a meaningful name, something like "lastpy2pep8". It should be a one-and-done sorry of thing and make it easier for people still maintaining tools which support Python 2 (such as the pep8 app in PyPI) to refer to (or to publish).

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants