PEP 558: Incorporate review comments from python-dev posting #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix miscellaneous typos * Remove an outdated mention of possibly dropping suport for storing extra f_locals keys in optimised scopes * Make it more explicit that accessing frame.f_locals in Python refreshes the f_locals cache on that frame
* GetReturnsCopy -> GetKind * Reference Jan/Feb 2021 python-dev threads * Note that read-only views on optimised frames have the same cache consistency limitations as the read/write proxy does.
ncoghlan
changed the title
|
Ah, I should have put the in-progress label on this one - I was going to wait until @njsmith had provided comments on the posted version before publishing the update :) No worries though, as I doubt replacing the clunky boolean query API with an enum is going to prove controversial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extra f_locals keys in optimised scopes
refreshes the f_locals cache on that frame
consistency limitations as the read/write proxy