Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 634: Clarify late-registration edge-case #2001

Merged
merged 2 commits into from
Jun 24, 2021
Merged

PEP 634: Clarify late-registration edge-case #2001

merged 2 commits into from
Jun 24, 2021

Conversation

brandtbucher
Copy link
Member

...as requested by @markshannon in python/cpython#26864.

Also, add myself as a CODEOWNER of PEPs 635 and 636.

@brandtbucher brandtbucher requested review from gvanrossum and a team as code owners June 24, 2021 17:00
@brandtbucher brandtbucher merged commit c043875 into python:master Jun 24, 2021
gvanrossum
gvanrossum reviewed Jun 25, 2021
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice corner case! LGTM.

@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum left review comments

@brettcannon brettcannon brettcannon approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brandtbucher @brettcannon @gvanrossum @the-knights-who-say-ni