Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 458: update list of authors #1295

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

trishankatdatadog
Copy link
Contributor

@mnm678 Any objections?

Copy link
Contributor

@mnm678 mnm678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rosuav
Copy link
Contributor

Rosuav commented Feb 4, 2020

It looks like the build system wants consistent email addresses for people, and PEP 480 has a different address @trishankatdatadog . Was your intention to change your address across the board? If so, just add a commit changing PEP 480 as well. If you wanted to have different addresses on different PEPs, though, I'm not sure how to do that.

@trishankatdatadog
Copy link
Contributor Author

@Rosuav Done, thanks :)

@Rosuav
Copy link
Contributor

Rosuav commented Feb 4, 2020

LGTM!

@Rosuav Rosuav merged commit 5a9de97 into python:master Feb 4, 2020
@trishankatdatadog trishankatdatadog deleted the pep458/update-authors branch February 4, 2020 18:02
mnm678 pushed a commit to mnm678/peps that referenced this pull request Oct 22, 2020
* update authors

* update email address & acknowledgements
@di di mentioned this pull request Feb 1, 2022
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants