Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 458: Change title to clarify intent #1247

Merged
merged 2 commits into from
Jan 3, 2020

Conversation

brainwane
Copy link
Contributor

Change "link" which misleadingly implied transport level
security.

Signed-off-by: Sumana Harihareswara <sh@changeset.nyc>
@brainwane
Copy link
Contributor Author

@mnm678 Please feel free to supersede this with secure-systems-lab#77; should I close this PR?

@mnm678
Copy link
Contributor

mnm678 commented Dec 21, 2019

@brainwane I was planning to collect changes in the secure-systems-lab fork, but we can do them individually here if that would be preferable.

@ncoghlan
Copy link
Contributor

@mnm678 While it does vary between cases, incremental updates are often a good idea, to avoid having to go over previously discussed ground with new readers.

@mnm678
Copy link
Contributor

mnm678 commented Jan 3, 2020

@ncoghlan Ok! I added #1268 to reflect the other changes discussed (specifically the updated abstract) and will close secure-systems-lab#77.

@pradyunsg
Copy link
Member

I think this is unanimously OK'ed on the corresponding discussion thread.

Could a PEP editor please take merge this/tell us what is needed to do so?

@Rosuav
Copy link
Contributor

Rosuav commented Jan 3, 2020

@dstufft has been pinged for review; can anyone either link to a statement from him in support of this, or some other indication that we're not violating his wishes? (I quickly skimmed the thread but my Discourse-fu is not strong and I can't be sure it wasn't there.) Other than that, I can merge this in no problem.

@Rosuav Rosuav merged commit 99dd06f into python:master Jan 3, 2020
@Rosuav
Copy link
Contributor

Rosuav commented Jan 3, 2020

LGTM! Thanks for confirming.

mrkmndz pushed a commit to mrkmndz/peps that referenced this pull request Jan 3, 2020
* PEP 458: Change title to clarify intent

Per conversation in
https://discuss.python.org/t/pep-458-surviving-a-compromise-of-pypi/2648/21

about problems with current title, and and per former PEP coauthor
Vladimir Diaz in
https://mail.python.org/archives/list/distutils-sig@python.org/thread/TXM2O34TMSHH5U6WA2IF7XKO5J3G5NQQ/#3QLN4KECII6KULKYXS7U4CVBEPGK4B6S

Signed-off-by: Sumana Harihareswara <sh@changeset.nyc>

* PEP 458: Improve title

Change "link" which misleadingly implied transport level
security.

Signed-off-by: Sumana Harihareswara <sh@changeset.nyc>
@brainwane brainwane deleted the pep-458-title branch May 29, 2020 14:43
@di di mentioned this pull request Feb 1, 2022
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants