-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_typeddict_errors fails on python3.11 #24
Comments
I cannot repro this yet. Which version of Python 3.11 did you use? rc2? What platform? What version of mypy? Accelerated through mypyc or not? |
I'm in the process of updating to mypy 0.971 and can retest if that helps. Except mypy is not part of the environment during testing, so that seems pointless. |
Ah, I was confused. I've confirmed your report on macOS. I didn't try earlier versions of Python 3.11, but the tests pass with 3.10. Do you have time to debug this further? I'm guessing something in the stdlib typing.py module changed, but I don't have time to investigate further. |
Works on 3.11.0a6, broke on 3.11.0a7. I'm not too familiar with the cpython codebase and I don't have a setup ready to bisect this any further. |
@JelleZijlstra -- what could have broken this? It seems to be this code at L91-92 that no longer raises with self.assertRaises(TypeError):
TypedDict('Hi', x=1) A lot of stuff went in between a6 and a7, including PEP 646, and a bunch of refactoring by Serhiy. |
I think that's because of 870b22b9c442d035190d2b8fb82256cd9a03da48 (python/cpython#31151). |
So the test should just be fixed. |
Integers are now accepted as types in many runtime contexts: python/cpython#90802 Fixes #24.
Integers are now accepted as types in many runtime contexts: python/cpython#90802 Fixes #24.
Heads up, we're seeing a test failure with python 3.11.0rc2 and mypy_extensions. Python 3.11 will be released in October.
The text was updated successfully, but these errors were encountered: