Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[very much a wip] pep 612 #9250

Closed
wants to merge 19 commits into from
Closed

Conversation

hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented Aug 3, 2020

Tracking issue for PEP 612: #8645

@JukkaL
Copy link
Collaborator

JukkaL commented Aug 7, 2020

Thanks for working on this! This addresses a common user pain point.

I haven't had time to look at this in detail, but here are some general thoughts. The implementation doesn't need to be complete before merging -- maintaining a big PR over time gets tedious. Tests need to pass, of course. One option would be to add a command-line flag for enabling experimental features. Another option would be to document the feature as experimental until it's fully implemented and enable it always (this is what we've done previously).

JukkaL pushed a commit that referenced this pull request Sep 8, 2020
Linking #8645

Like #9339, much of this is in #9250. However, this PR is a little less self 
contained, in that it causes several future TODOs.

A lot of the changes here are necessitated by changing the type of 
CallableType.variables to Sequence[TypeVarLikeDef]. This is nice, because 
it informs me where I need to make changes in the future / integrates a little 
bit better with existing type var stuff.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants