Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mypyc] Implement lowering for remaining tagged integer comparisons #17040

Merged
merged 11 commits into from
Mar 19, 2024

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Mar 16, 2024

Support lowering of tagged integer <, <=, > and >= operations.

Previously we had separate code paths for integer comparisons in values vs conditions. Unify these and remove the duplicate code path. The different code paths produced subtly different code, but now they are identical.

The generated code is now sometimes slightly more verbose in the slow path (big integer). I may look into simplifying it in a follow-up PR.

This also makes the output of many irbuild test cases significantly more compact.

Follow-up to #17027. Work on mypyc/mypyc#854.

@JukkaL JukkaL merged commit afdd9d5 into master Mar 19, 2024
13 checks passed
@JukkaL JukkaL deleted the mypyc-lowering-2 branch March 19, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants