Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mypyc] Provide an easier way to define IR-to-IR transforms #16998

Merged
merged 17 commits into from
Mar 9, 2024

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Mar 8, 2024

This makes it easy to define simple IR-to-IR transforms by subclassing IRTansform and overriding some visit methods.

Add an implementation of a simple copy propagation optimization as an example.

This will be used by the implementation of mypyc/mypyc#854, and this can also be used for various optimizations.

The IR transform preserves the identities of ops that are not modified. This means that the old IR is no longer valid after the transform, but the transform can be fast since we don't need to allocate many objects if only a small subset of ops will be modified by a transform.

@JukkaL
Copy link
Collaborator Author

JukkaL commented Mar 8, 2024

cc @ilevkivskyi @msullivan

Copy link
Collaborator

@jhance jhance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned before, we can implement generalized test fixture on the next IR transform we add.

@JukkaL JukkaL merged commit c94d8e3 into master Mar 9, 2024
13 checks passed
@JukkaL JukkaL deleted the mypyc-ir-transform branch March 9, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants